[Backport 6.10.x] Fix/Helm: Port names in Helm chart #769
+221
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Istio uses the first part of a port name, and service definitions, to configure its service mesh sidecar proxy containers, based on the expected traffic type; docs: https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection - The `http-` prefix in the port name wasn't updated when we switched to gRPC, so Istio was auto-configuring for http, and failing to send the gRPC traffic - Making these updates automagically fixes Istio issues, no longer requiring the Envoy patch in [charts/sourcegraph/examples/envoy](https://github.com/sourcegraph/deploy-sourcegraph-helm/tree/main/charts/sourcegraph/examples/envoy) - Helpful background on Istio here: https://istio.io/latest/docs/ops/deployment/architecture/ ### Checklist - [x] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [ ] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [ ] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes) This change should be invisible, except potentially for customers using the Envoy patch for gitserver ### Test plan Developed and tested with a customer, on their self-hosted instance with Istio Tested on a k3s instance: - Deployed the 6.9.0 release - Upgraded the Helm install with this branch [marc-test-fix-gitserver-ports-for-istio](https://github.com/sourcegraph/deploy-sourcegraph-helm/tree/marc-test-fix-gitserver-ports-for-istio), which is the same code changes, but on top of the v6.9.0 release commit instead of main, to test for any issues for existing customers as they upgrade - Configured a code host - Cloned some repos - Ran some searches - Checked pod logs - No errors / issues Also tested on an AWS EKS instance (cherry picked from commit 0074a7e)
marcleblanc2
approved these changes
Nov 14, 2025
Contributor
|
Note to self: Update the admin update docs page with the correct patch number once this gets released |
DaedalusG
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer was blocked on an issue with our Helm chart + Istio
Istio uses the first part of a port name, and service definitions, to configure its service mesh sidecar proxy containers, based on the expected traffic type; docs: https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection
The
http-prefix in the port name wasn't updated when we switched to gRPC, so Istio was auto-configuring for http, and failing to send the gRPC trafficThere was an old
unusedport in the gitserver service definition, which I couldn't find any history for, it's been there for 7+ years, so I added gRPC port 3178 in its placeMaking these updates automagically fixes Istio issues, no longer requiring the Envoy patch in charts/sourcegraph/examples/envoy
Helpful background on Istio here https://istio.io/latest/docs/ops/deployment/architecture/
Checklist
This change should be invisible, except for customers using the Envoy patch for gitserver, so it's worth mentioning in release notes, where do you recommend I mention this?
Test plan
Developed and tested with a customer, on their self-hosted instance with Istio
Tested on a k3s instance:
Tested on an AWS EKS instance
Backport 0074a7e from #756
Changelog