This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Make solana root key accessible on Ledger #8421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
previously approved these changes
Feb 24, 2020
aa82f79 to
baca8c4
Compare
Pull request has been modified.
baca8c4 to
95bb90f
Compare
95bb90f to
1d26b8b
Compare
Contributor
|
😱 New commits were pushed while the automerge label was present. |
Contributor
|
😱 New commits were pushed while the automerge label was present. |
Contributor
|
💔 Unable to automerge due to CI failure |
5f7d192 to
8e34918
Compare
Contributor
|
💔 Unable to automerge due to CI failure |
Codecov Report
@@ Coverage Diff @@
## master #8421 +/- ##
========================================
- Coverage 80.2% 80.2% -0.1%
========================================
Files 253 253
Lines 55975 55982 +7
========================================
- Hits 44929 44925 -4
- Misses 11046 11057 +11 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Use 44/501 key as ledger id * Add error codes (cherry picked from commit b775512)
solana-grimes
pushed a commit
that referenced
this pull request
Feb 25, 2020
CriesofCarrots
added a commit
to CriesofCarrots/solana
that referenced
this pull request
Feb 26, 2020
* Use 44/501 key as ledger id * Add error codes
CriesofCarrots
added a commit
that referenced
this pull request
Feb 27, 2020
…#8487) * CLI: dynamic signing reboot (#8384) * Add keypair_util_from_path helper * Cli: impl config.keypair as a trait object * SDK: Add Debug and PartialEq for dyn Signer * ClapUtils: Arg parsing from pubkey+signers to Presigner * Impl Signers for &dyn Signer collections * CLI: Add helper for getting signers from args * CLI: Replace SigningAuthority with Signer trait-objs * CLI: Drop disused signers command field * CLI: Drop redundant tests * Add clap validator that handles all current signer types * clap_utils: Factor Presigner resolution to helper * SDK: `From` for boxing Signer implementors to trait objects * SDK: Derive `Clone` for `Presigner` * Remove panic * Cli: dedup signers in transfer for remote-wallet ergonomics * Update docs vis-a-vis ASK changes * Cli: update transaction types to use new dynamic-signer methods * CLI: Fix tests No. 1 what to do about write_keypair outstanding * Work around `CliConfig`'s signer not necessarily being a `Keypair` * CLI: Fix tests No. 2 * Remove unused arg * Remove unused methods * Move offline arg constants upstream * Make cli signing fallible Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com> * Reinstate `create-stale-account` w/ seed test (#8401) automerge * CLI: collect and deduplicate signers (#8398) * Rename (keypair util is not a thing) * Add method to generate_unique_signers * Cli: refactor signer handling and remote-wallet init * Fixup unit tests * Fixup intergation tests * Update keypair path print statement * Remove &None * Use deterministic key in test * Retain storage-account as index * Make signer index-handling less brittle * Cache pubkey on RemoteKeypair::new * Make signer_of consistent + return pubkey * Remove &matches double references * Nonce authorities need special handling * Make solana root key accessible on Ledger (#8421) * Use 44/501 key as ledger id * Add error codes * Ledger key path rework (#8453) automerge * Ledger hardware wallet docs (#8472) * Update protocol documentation * Correct app-version command const * Rough initial Ledger docs * Add more docs * Cleanup * Add remote-wallet to docs TOC Co-authored-by: Greg Fitzgerald <greg@solana.com> * Add flag to confirm key on device Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com> Co-authored-by: Greg Fitzgerald <greg@solana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solana apis erroneously return derivation path
44/501/0as the solana root on a Ledger Wallet, when it should be the key at44/501Summary of Changes
Make path
44/501accessible and use as Ledger base pubkey for identification purposes.Update default DerivationPath to be
account: None, change: NoneAlso, including some error code specifics that aren't recognized by the remote-wallet ledger api to be more efficient through CI.
Fixes #8408