这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@t-nelson
Copy link
Contributor

@t-nelson t-nelson commented Feb 4, 2020

Problem

The helper function for parsing sign_only replies is buried in the staking tests, despite being helpful anywhere offline signing is tested

Summary of Changes

Expose it.
De-replicode

@t-nelson t-nelson added automerge Merge this Pull Request automatically once CI passes v0.23 labels Feb 4, 2020
@solana-grimes solana-grimes merged commit 7924936 into solana-labs:master Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #8107 into master will decrease coverage by <.1%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #8107     +/-   ##
========================================
- Coverage      82%     82%   -0.1%     
========================================
  Files         249     249             
  Lines       53431   53445     +14     
========================================
- Hits        43846   43845      -1     
- Misses       9585    9600     +15

mergify bot pushed a commit that referenced this pull request Feb 4, 2020
automerge

(cherry picked from commit 7924936)
solana-grimes pushed a commit that referenced this pull request Feb 4, 2020
@t-nelson t-nelson deleted the cli-expose_sign_only_helper branch February 4, 2020 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants