This repository was archived by the owner on Jan 22, 2025. It is now read-only.
CLI: Implement transfer command #8108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ce07c2 to
fe8f65a
Compare
fe8f65a to
13f5935
Compare
mvines
previously approved these changes
Feb 7, 2020
Comment on lines
+404
to
+409
| sign_only: bool, | ||
| signers: Option<Vec<(Pubkey, Signature)>>, | ||
| blockhash_query: BlockhashQuery, | ||
| nonce_account: Option<Pubkey>, | ||
| nonce_authority: Option<SigningAuthority>, | ||
| fee_payer: Option<SigningAuthority>, |
Contributor
There was a problem hiding this comment.
All this boilerplate across various cli commands is getting a little much (seems ripe for future cleanup, not here!)
Contributor
Author
There was a problem hiding this comment.
💯
A refactor has been rattling around in my brain throughout this whole offline fixup session. I've been jotting down notes as I transition back to snapshot verification and will surface the gems as issues
Codecov Report
@@ Coverage Diff @@
## master #8108 +/- ##
========================================
- Coverage 81.9% 81.8% -0.1%
========================================
Files 245 248 +3
Lines 53691 53936 +245
========================================
+ Hits 43977 44152 +175
- Misses 9714 9784 +70 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2020
* CLI: Add transfer subcommand * Add tests * checks (cherry picked from commit 87c6508)
solana-grimes
pushed a commit
that referenced
this pull request
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
paysubcommand is overloaded withBudgetProgramfeatures, which are disabled for SLP1/2Summary of Changes
Factor out the system transfer portion of
payto a newtransfersubcommand (with offline/nonce support)Requires #8009 and #8107