This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Reduce rpc client pre-flight requests by setting max-age header #8082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8082 +/- ##
========================================
+ Coverage 82% 82% +<.1%
========================================
Files 249 249
Lines 53303 53304 +1
========================================
+ Hits 43710 43714 +4
+ Misses 9593 9590 -3 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2020
automerge (cherry picked from commit 69a6d07)
solana-grimes
pushed a commit
that referenced
this pull request
Feb 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Noticed in the "Break Solana" dapp that the browser was sending many pre-flight options requests. Turns out our RPC http server is not setting the
Access-Control-Max-AgeheaderSummary of Changes
Set max duration (24hr) for cors max age
(verified this works)
Fixes #