This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix cleanup_paths #3062
Merged
Fix cleanup_paths #3062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Mar 2, 2019
2af5e42 to
574e0eb
Compare
Codecov Report
@@ Coverage Diff @@
## master #3062 +/- ##
========================================
- Coverage 77.8% 73.9% -3.9%
========================================
Files 135 133 -2
Lines 20287 21370 +1083
========================================
+ Hits 15784 15802 +18
- Misses 4503 5568 +1065 |
Codecov Report
@@ Coverage Diff @@
## master #3062 +/- ##
========================================
- Coverage 77.8% 75.6% -2.2%
========================================
Files 135 135
Lines 20287 20842 +555
========================================
- Hits 15785 15762 -23
- Misses 4502 5080 +578 |
Add back remove of parent in Accounts::drop, but remove that in the cleanup_paths helper for the account tests which do not use make_default_dir.
574e0eb to
00cef6b
Compare
garious
approved these changes
Mar 3, 2019
rob-solana
reviewed
Mar 3, 2019
| let paths = if in_paths.is_none() { | ||
| Self::make_default_paths() | ||
| let (paths, own_paths) = if in_paths.is_none() { | ||
| (Self::make_default_paths(), true) |
Contributor
There was a problem hiding this comment.
which code passes None for in_paths, now?
Contributor
Author
There was a problem hiding this comment.
Basically all the tests which create banks, in_paths is really only populated when the --accounts argument is passed to fullnode from the command line.
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Oct 10, 2024
…olana-labs#3052) (solana-labs#3062) * ci: ignore the tonic audit as a temporary stopgap (solana-labs#3052) (cherry picked from commit 9b5525d) # Conflicts: # ci/do-audit.sh * Fix conflicts * Update to mimic v2.0 change --------- Co-authored-by: Yihau Chen <yihau.chen@icloud.com> Co-authored-by: WillHickey <will.hickey@anza.xyz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing path cleanup in account_not_found test and no cleanup of created parent dir when default paths are created by Accounts object.
Summary of Changes
Add back remove of parent in Accounts::drop, but
remove that in the cleanup_paths helper
for the account tests which do not use
make_default_dir.
Fixes #