这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 6, 2017

sans is not a valid generic font-family, see https://www.w3.org/TR/CSS2/fonts.html#generic-font-families

@sofish
Copy link
Owner

sofish commented Feb 6, 2017

im not trying to develop a tool that valid but to make a website looks better

thanks

@sofish sofish closed this Feb 6, 2017
@JLHwung
Copy link
Contributor Author

JLHwung commented Feb 6, 2017

I am wondering why using sans here will make a website looks better since sans is not valid generic font family and the browser will simply ignore this value. If so, sans should be deleted.

@sofish
Copy link
Owner

sofish commented Feb 6, 2017

not because of sans or sans-serif but the whole lib,
pull-request that makes a website looks better will be merged but not one that makes valid

@JLHwung
Copy link
Contributor Author

JLHwung commented Feb 6, 2017

After browsing on the history I found that sans-serif was replaced by sans in 5c96950, could you explain why sans-serif should be replaced by sans here? Is it related to any WebKit bugs? Thank you.

@sofish
Copy link
Owner

sofish commented Feb 6, 2017

after a review, i think you are right on this
thanks, again

@sofish sofish reopened this Feb 6, 2017
@sofish sofish merged commit f5d6cb5 into sofish:master Feb 6, 2017
@JLHwung
Copy link
Contributor Author

JLHwung commented Feb 6, 2017

You are very welcome.

@JLHwung JLHwung deleted the patch-1 branch February 6, 2017 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants