Fixes HMR for ES modules #8
Conversation
| // babel did not transform modules | ||
| // eslint-disable-next-line no-underscore-dangle | ||
| component = module.__esModule ? module.default : module; | ||
| component = ctx.__esModule ? ctx.default : ctx; |
There was a problem hiding this comment.
From my tests there was always a default property on the object (even if that's all that's being exported), so maybe we could just drop this and test for default ? Not sure what to do when there are no default and only named exports ?
There was a problem hiding this comment.
That's a good question. I guess we should just take care of the default export (I think that's how vue-loader works, too).
There was a problem hiding this comment.
Yeah, you're right, that's what they (vue-loader) seem to do. But is it *.vue files that don't support named export or vue-hot-reload-api that doesn't like it or something ?
There was a problem hiding this comment.
I guess it's not supported because there's no way to determine what's a Vue object or something completely unrelated.
|
Perfect! Now it really works. Thank you so much. |
Pass in
thisasctxto the API, which reference the updated native ES module. There seems to be a reference to the module inmodule.__proto__.exports.abut (1) it seems weird to use that, and (2) it doesn't work with it as it doesn't have thebeforeCreateand al. hooks fromvue-hot-reload-api. Not surectxis the best name for that variable but.. that's what I got.ref: #7