这是indexloc提供的服务，不要输入任何密码
Skip to content

Wrap item.toString() call in a helper function #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2017
Merged

Wrap item.toString() call in a helper function #15

merged 1 commit into from
Nov 21, 2017

Conversation

@ikorolev93
Copy link
Collaborator

@ikorolev93 ikorolev93 commented Nov 21, 2017

When transformUnserializableProps encounters an object, that doesn't have Object in the prototype hierarchy, it tries to call .toString and crashes. This PR makes it call Object.prototype.toString instead.

@skyrpex skyrpex merged commit c3cad34 into skyrpex:master Nov 21, 2017
@skyrpex
Copy link
Owner

skyrpex commented Nov 21, 2017

Thank you so much! I never encountered that case, personally. How can an object not to have .toString?

@ikorolev93
Copy link
Collaborator Author

ikorolev93 commented Nov 21, 2017

For example

const o = Object.create(null);
console.log(o.toString); // undefined

@skyrpex
Copy link
Owner

skyrpex commented Nov 21, 2017

Thanks. I'll have to add some tests soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ikorolev93 @skyrpex