Memo filter #12
Closed
Memo filter #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the memo validation logic for Soroban transactions by removing the distinction between source account-only authentication and other authentication types. Previously, transactions with source account-only authentication were exempt from memo restrictions, but this exemption has been removed.
- Simplifies memo validation by removing source account authentication type checks
- Updates test expectations to reflect stricter memo validation rules
- All Soroban transactions with memos or muxed accounts are now rejected regardless of authentication type
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/herder/TransactionQueue.cpp | Removes source account authentication exemption from memo validation logic |
| src/herder/test/TransactionQueueTests.cpp | Updates test to expect error status instead of pending for transactions with memos |
| copilot-instructions.md | Adds new instruction file for code review guidelines (unrelated to memo filter functionality) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #X
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)