Update sentry.filter.ts #8
Conversation
|
|
||
| captureException(exception: Error) { | ||
| Sentry.captureException(exception); | ||
| captureException(exception: Error,flag: any) { |
There was a problem hiding this comment.
Issue: New flag parameter in captureException method
Reason: The captureException method now includes a new 'flag' parameter that conditionally calls Sentry.captureException.
Affected dependencies:
• packages/sentry-plugin/src/sentry.service.ts - captureException: Method now requires an additional parameter that may affect existing calls
Suggestion: Ensure all callers of captureException provide the new 'flag' parameter. Consider using a boolean type for the flag instead of any.
Required changes in dependencies:
• packages/sentry-plugin/src/sentry.service.ts - captureException: Update all instances where captureException is called to include the new flag parameter.
|
|
||
| captureException(exception: Error) { | ||
| Sentry.captureException(exception); | ||
| captureException(exception: Error,flag: any) { |
There was a problem hiding this comment.
Issue: The captureException function now includes an additional parameter flag, which affects how exceptions are captured.
Reason: Adding a new parameter changes the method signature, requiring all dependent files to update their calls to this function. If they do not provide the new parameter, it will result in a runtime error or unexpected behavior.
Affected dependencies:
• packages/sentry-plugin/src/sentry-error-handler-strategy.ts - captureException: The function call to captureException does not include the new flag parameter.
• packages/sentry-plugin/src/sentry.filter.ts - captureException: The function call to captureException does not include the new flag parameter.
• packages/sentry-plugin/src/api/admin-test.resolver.ts - captureException: The function call to captureException does not include the new flag parameter.
Suggestion: Check all instances where captureException is called and ensure that the new flag parameter is provided. Verify if the logic of these calls should now depend on the flag parameter.
Required changes in dependencies:
• packages/sentry-plugin/src/sentry-error-handler-strategy.ts - captureException: Update all calls to captureException in this file by adding the flag parameter. Determine an appropriate value for flag based on the context of these calls.
• packages/sentry-plugin/src/sentry.filter.ts - captureException: Update all calls to captureException in this file by adding the flag parameter. Determine an appropriate value for flag based on the context of these calls.
• packages/sentry-plugin/src/api/admin-test.resolver.ts - captureException: Update all calls to captureException in this file by adding the flag parameter. Determine an appropriate value for flag based on the context of these calls.
There was a problem hiding this comment.
| captureException(exception: Error,flag: any) { | |
| captureException(exception: Error,flag: any) { |
There was a problem hiding this comment.
| captureException(exception: Error,flag: any) { | |
| captureException(exception: Error,flag: any) { |
hey i am yashwanth
Description
Please include a summary of the changes and the related issue.
Breaking changes
Does this PR include any breaking changes we should be aware of?
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: