这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@shubhrec
Copy link
Owner

@shubhrec shubhrec commented Mar 2, 2025

Description

Please include a summary of the changes and the related issue.

Breaking changes

Does this PR include any breaking changes we should be aware of?

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

}
this.sentryService.captureException(exception);
this.sentryService.captureException(exception,true);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Additional parameter in function call

Reason: captureException is called with an additional boolean parameter that the method does not accept.

Affected dependencies:
• packages/sentry-plugin/src/sentry.service.ts - captureException: Method does not accept additional parameter

Suggestion: Update captureException method to handle the new boolean parameter or remove it from the call.

Required changes in dependencies:
• packages/sentry-plugin/src/sentry.service.ts - captureException: Modify captureException to accept and handle the boolean parameter

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there was a misunderstanding. The issue is not with the captureException method in sentry.service.ts, but rather with the Sentry SDK itself, which does not support this additional flag parameter. We need to ensure that either the Sentry SDK version supports this change or update the code to align with the SDK's API.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there was a misunderstanding. The captureException function now includes an additional parameter flag. All calls to this function need to be updated accordingly in the affected files, not just modifying the method signature. Please ensure that all instances where captureException is called include the new flag parameter with an appropriate value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants