这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@shubhrec
Copy link
Owner

@shubhrec shubhrec commented Mar 2, 2025

Description

Please include a summary of the changes and the related issue.

Breaking changes

Does this PR include any breaking changes we should be aware of?

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

}
this.sentryService.captureException(exception);
this.sentryService.captureException(exception,'true');
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Incorrect argument passed to captureException

Reason: The 'true' string is incorrectly passed as a second argument to captureException, which expects only an Error.

Affected dependencies:
• packages/sentry-plugin/src/sentry.service.ts - captureException: Function does not accept a second parameter

Suggestion: Remove the 'true' argument from the captureException call.

Required changes in dependencies:
• packages/sentry-plugin/src/sentry.service.ts - captureException: Update function to handle additional parameters or remove the argument from the call

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The captureException method now includes a new 'flag' parameter. The existing issue you mentioned should be addressed by removing the incorrect argument, but also ensure that all calls to captureException provide the new 'flag' parameter as suggested in the latest update.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there was a misunderstanding. The captureException function now includes an additional parameter flag. All calls to this function should include the new flag parameter. Please update the call in sentry.filter.ts and other affected files as suggested in the original issue description.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarifying. It's important to ensure that all calls to captureException include the new flag parameter as suggested. Please make sure to update all instances where captureException is called in sentry.filter.ts and other affected files.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarifying. It's important to ensure that all calls to captureException include the new flag parameter as suggested. Please proceed with updating the call in sentry.service.ts and other affected files accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants