-
Notifications
You must be signed in to change notification settings - Fork 0
Update sentry.filter.ts #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| } | ||
| this.sentryService.captureException(exception); | ||
| this.sentryService.captureException(exception,'true'); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: Incorrect argument passed to captureException
Reason: The 'true' string is incorrectly passed as a second argument to captureException, which expects only an Error.
Affected dependencies:
• packages/sentry-plugin/src/sentry.service.ts - captureException: Function does not accept a second parameter
Suggestion: Remove the 'true' argument from the captureException call.
Required changes in dependencies:
• packages/sentry-plugin/src/sentry.service.ts - captureException: Update function to handle additional parameters or remove the argument from the call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The captureException method now includes a new 'flag' parameter. The existing issue you mentioned should be addressed by removing the incorrect argument, but also ensure that all calls to captureException provide the new 'flag' parameter as suggested in the latest update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there was a misunderstanding. The captureException function now includes an additional parameter flag. All calls to this function should include the new flag parameter. Please update the call in sentry.filter.ts and other affected files as suggested in the original issue description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for clarifying. It's important to ensure that all calls to captureException include the new flag parameter as suggested. Please make sure to update all instances where captureException is called in sentry.filter.ts and other affected files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for clarifying. It's important to ensure that all calls to captureException include the new flag parameter as suggested. Please proceed with updating the call in sentry.service.ts and other affected files accordingly.
Description
Please include a summary of the changes and the related issue.
Breaking changes
Does this PR include any breaking changes we should be aware of?
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: