ping @mrpaulblack

another PR is required to update the tabs in the preferences:

• so the user can use the Tab key to navigate
• to fix Preferences, cookies tab bug #945

Agreed. Sorry I put the review off again and again so after Markus tested it I am also for merging (Looking at the files the aria labels seems clear IMO 👍 and the reset works)

@dalf After some more testing the new reset impl. does not clear the input filed when the user already searched for something. It will only reset to the search term that the user searched for...

That's the expect behavior of a reset button

From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/reset :

elements of type reset are rendered as buttons, with a default click event handler that resets all of the inputs in the form to their initial values

I don't know how to clear the input without JS.

Fix for the JS version:

diff --git a/searx/static/themes/simple/src/js/main/search.js b/searx/static/themes/simple/src/js/main/search.js
index 6ef95f5b..1fb0a7cb 100644
--- a/searx/static/themes/simple/src/js/main/search.js
+++ b/searx/static/themes/simple/src/js/main/search.js
@@ -31,10 +31,11 @@
 
     // update status, event listener
     updateClearButton();
-    cs.addEventListener('click', function () {
+    cs.addEventListener('click', function (ev) {
       qinput.value = '';
       qinput.focus();
       updateClearButton();
+      ev.preventDefault();
     });
     qinput.addEventListener('keyup', updateClearButton, false);
   }

only happens with the non JS version tho;
I am reading: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input maybe there is some attribute for input to get around this?

<input type="search" may include a clear button (on Chrom(e|ium) browser, but not on FF).

@dalf so first of all I misunderstood an that issue happens in both JS and non JS version in current master. I tried around for a while in HTML, but looks like this is not really possible since it will always reset to value. If you have time could you please make a PR with the JS fix? I mean this way it at least works with JS and kinda works with no JS 👍

[EDIT] qwant has the same problem without JS: https://www.qwant.com/?q=time