[fix] calculator plugin: subrocess is not closed on timeout #4983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was introduced in commit: edfbf1e Problematic code:: def timeout_func(timeout, func, *args, **kwargs): ... if not p.is_alive(): ret_val = que.get() else: logger.debug("terminate function after timeout is exceeded") # type: ignore p.terminate() p.join() p.close() The `logger` function in the `else` path is not defined. Was accidentally removed in commit edfbf1e without providing an appropriate replacement.:: File "/usr/local/searxng/searx/plugins/calculator.py", line 216, in timeout_func logger.debug("terminate function after timeout is exceeded") # type: ignore ^^^^^^ NameError: name 'logger' is not defined The exception triggered by this prevents the `p.terminate()` from being executed. As a result, the processes accumulate in memory (memory leak). Related: searxng/searx-instances#708 (reply in thread) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Member
|
Nicely done, will test asap |
vojkovic
approved these changes
Jul 8, 2025
Bnyro
approved these changes
Jul 8, 2025
Member
|
related: #4938 |
Member
|
Why do we have so many type overrides anyway? |
Member
Author
Because we (e.g. in the engines) are doing a lot of monkey patching .. because we have a lot of old code that doesn't know typing .. we are in the process of gradually improving this; here are two examples.
As the PRs show, typing is a huge task .. often, entire parts of a existing model have to be rethought /re-implemented .. it will take a very long time before we can remove most of the type overrides... but there will always be a residue of overwrites... we shouldn't forget: Python is and remains a dynamically typed language. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was introduced in commit: edfbf1e
Problematic code:
The
loggerfunction in theelsepath is not defined. Was accidentally removed in commit edfbf1e without providing an appropriate replacement.The exception triggered by this prevents the
p.terminate()from being executed. As a result, the processes accumulate in memory (memory leak).Related: