[mod] container: allow immutable config #4851
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
Author
|
But that PR is not ready yet and it might take a couple more weeks to be, I'll rebase the changes there. For now, let's focus on what we have now. |
Contributor
|
I would prefer to not change around the GHA every day, it's becoming quite difficult to follow. We have a temporary solution from searxng/searxng-docker#375, we know it's not great, hence why I created a PR to revert searxng/searxng-docker#385. But it works for now. I would rather spend more time in testing granian (#4820) than introducing changes that will get obsolete at some point with granian. |
Remove the patch functions and ENVs abstraction from the entrypoint, this makes it possible to run the container with immutable configuration required in some setups. In other setups, it may be required to have the volumes/files under a specific uid/gid (other than searxng:searxng), if the entrypoint has root permissions will correct this, which may not be desired. Explicitly setting the new ENV `FORCE_OWNERSHIP=false` will prevent ownership from being modified. There are also some minor consistency changes. Related: searxng#4818
Member
Author
|
All right, I'll merge the changes there #4820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the patch functions and ENVs abstraction from the entrypoint, this makes it possible to run the container with immutable configuration required in some setups.
In other setups, it may be required to have the volumes/files under a specific uid/gid (other than searxng:searxng), if the entrypoint has root permissions will correct this, which may not be desired. Explicitly setting the new ENV
FORCE_OWNERSHIP=falsewill prevent ownership from being modified.There are also some minor consistency changes.
Related: #4818
Latest CI: https://github.com/inetol/searxng/actions/runs/15237554045