[fix] Revert "fix: check if the browser supports Sec-Fetch headers (#4696)" #4807
+14
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
How do you know that these are not legitimate users instead:
? Any insights to share? Screenshots or explanation about real data? |
…earxng#4696)" Many bots will probably use other user agents than the common ones (or rotate different ones)[1]. On my instance I can observe how bots with other UA headers are no longer stopped with the patch of PR searxng#4696. This reverts PR searxng#4696 commit 19b116f. [1] searxng#4696 (review) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Member
Author
|
FYI last force push was just a rebase on current master to solve a conflict / related: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many bots will probably use other user agents than the common ones (or rotate different ones)[1].
On my instance I can observe how bots with other UA headers are no longer stopped with the patch of PR #4696.
This reverts PR #4696 commit 19b116f.
[1] #4696 (review)
To be clear, I understand the intention of #4696 and think the reasoning is correct. However, I only see disadvantages for me in practice, which is why I am applying this patch to my instance and making it available to the community with this PR.
The PR is rebased in the event of conflicts with the master branch / it can simply be patched on top of your own instance via cherry picking.