这是indexloc提供的服务，不要输入任何密码
Skip to content

[enh] refactor data-update.yml workflow #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

[enh] refactor data-update.yml workflow #4732

merged 1 commit into from
May 8, 2025

Conversation

@inetol
Copy link
Member

@inetol inetol commented May 8, 2025

This PR is part of #4707

@inetol inetol requested a review from return42 May 8, 2025 11:08
@inetol @return42
[mod] CI: refactor data-update.yml - searxng_extra/update scripts
a0145e0 
Style changes, cleanup and improved integration with CI by leveraging the use of
shared cache between all workflows (not functional until all workflows have been
refactored).
@return42 return42 force-pushed the refactor-dataupdate branch from 038cce0 to a0145e0 Compare May 8, 2025 13:13
@return42 return42 merged commit c6a7078 into searxng:master May 8, 2025
7 checks passed
@return42
Copy link
Member

return42 commented May 8, 2025 •
edited
Loading

I manually started the "Update searx.data" action, but it fails when creating a PR

grafik

I can't explain why the PRs could still be created before this change, but now the permission is missing. Does it possibly have something to do with the fact that the “comitter” has changed?

Before: searxng-bot <noreply@github.com>

grafik

Now: searxng-bot <searxng-bot@users.noreply.github.com>

grafik

It has nothing to do with this change, but what I've been wondering for a long time is that my return42 account is used there as an author ... shouldn't that also be a neutral account?

searxng/.github/workflows/data-update.yml

Lines 65 to 66 in c6a7078

author: "${{ github.actor }} <${{ github.actor }}@users.noreply.github.com>"
committer: "searxng-bot <searxng-bot@users.noreply.github.com>"

@inetol
Copy link
Member Author

inetol commented May 8, 2025

It has nothing to do with this change, but what I've been wondering for a long time is that my return42 account is used there as an author ... shouldn't that also be a neutral account?

Well, you manually executed the workflow, so I think that's the expected thing to happen. Although it has nothing to do with the permission denied issue, I'll push a PR now.

@inetol inetol mentioned this pull request May 8, 2025
Merged
@inetol inetol deleted the refactor-dataupdate branch May 8, 2025 21:03
@return42
Copy link
Member

return42 commented May 9, 2025

Well, you manually executed the workflow, so I think that's the expected thing to happen.

Nope .. github.actor seems to the author from the commit that patches the workflow file.

.. now its you :-)

... shouldn't that also be a neutral account?

Bnyro pushed a commit to Bnyro/searxng that referenced this pull request Jun 25, 2025
@inetol @Bnyro
[mod] CI: refactor data-update.yml - searxng_extra/update scripts (se…
69f8a86 
…arxng#4732)

Style changes, cleanup and improved integration with CI by leveraging the use of
shared cache between all workflows (not functional until all workflows have been
refactored).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@return42 return42 Awaiting requested review from return42

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inetol @return42