[mod] rework container deployment #4764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the container deployment process by consolidating container-related build, test, and push logic while removing legacy Docker functions. Key changes include:
- Introducing new container.* functions (build, test, push) in lib_sxng_container.sh.
- Updating version retrieval and GitHub Actions integration for container operations.
- Removing deprecated docker functions and updating CI workflows and Makefile targets.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/lib_sxng_container.sh | Adds container.build, container.test, and container.push functions with engine checks. |
| searx/version.py | Adds GitHub Actions–specific branch and URL handling in get_git_url_and_branch. |
| manage | Removes legacy docker commands and adds container.* commands in the Makefile targets. |
| armv7.dockerfile | Introduces a dedicated Dockerfile configuration for ARMv7 architectures. |
| Makefile | Updates MANAGE targets to include podman and container commands. |
| Dockerfile | Adjusts build instructions to enable caching via --mount syntax. |
| .github/workflows/integration.yml | Removes outdated Docker workflow configuration. |
| .github/workflows/container.yml | Adds a new workflow for container build, test, and release with multi-arch support. |
container.yml will run after integration.yml COMPLETES successfully and in master branch. Style changes, cleanup and improved integration with CI by leveraging the use of shared cache between all workflows. * Podman is now supported to build the container images (Docker also received a refactor, merging both build and buildx) * Container images are being built by Buildah instead of Docker BuildKit. * Container images are tested before release. * Splitting "modern" (amd64 & arm64) and "legacy" (armv7) arches on different Dockerfiles allowing future optimizations.
b98c2fe to
2bc3057
Compare
dalf
approved these changes
May 11, 2025
`./container/` folder is the new folder for container related files including new Dockerfiles and config. `./container/legacy/` is dedicated to legacy architectures like armv7. Related Dockerfiles and configs go there.
return42
reviewed
May 11, 2025
return42
reviewed
May 11, 2025
Comment on lines
+53
to
+55
| case $parch in | ||
| "X64" | "x86_64" | "amd64") | ||
| dockerfile="Dockerfile" |
Member
There was a problem hiding this comment.
nitpicking: indentation can be fixed to 8 spaces .. related to #4707 (comment) .. but we can also standardize indentations later when you create the PR for a shell formater.
Member
Author
|
Note; Clean build: https://github.com/searxng/searxng/actions/runs/14957565596 |
return42
reviewed
May 11, 2025
inetol
added a commit
to inetol/searxng
that referenced
this pull request
May 12, 2025
inetol
added a commit
to inetol/searxng
that referenced
this pull request
May 12, 2025
return42
pushed a commit
to inetol/searxng
that referenced
this pull request
May 12, 2025
return42
pushed a commit
to inetol/searxng
that referenced
this pull request
May 12, 2025
return42
pushed a commit
that referenced
this pull request
May 12, 2025
return42
pushed a commit
that referenced
this pull request
May 12, 2025
felladrin
added a commit
to felladrin/MiniSearch
that referenced
this pull request
May 14, 2025
…XNG container Reference: searxng/searxng#4764
felladrin
added a commit
to felladrin/MiniSearch
that referenced
this pull request
May 14, 2025
…XNG container (#1108) Reference: searxng/searxng#4764
Bnyro
pushed a commit
to Bnyro/searxng
that referenced
this pull request
Jun 25, 2025
container.yml will run after integration.yml COMPLETES successfully and in master branch. Style changes, cleanup and improved integration with CI by leveraging the use of shared cache between all workflows. * Podman is now supported to build the container images (Docker also received a refactor, merging both build and buildx) * Container images are being built by Buildah instead of Docker BuildKit. * Container images are tested before release. * Splitting "modern" (amd64 & arm64) and "legacy" (armv7) arches on different Dockerfiles allowing future optimizations.
Bnyro
pushed a commit
to Bnyro/searxng
that referenced
this pull request
Jun 25, 2025
Bnyro
pushed a commit
to Bnyro/searxng
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes and is part of #4707
Closes #484