[fix] client/simple: add missing "swiped-events" devDependencies (import) #4586
Conversation
…ort) In commit 1a3543d in PR-4284 [1] the swiped-events [2] were forgotten to be migrated. In this patch, the event library is added to the ``devDependencies`` and imported by:: import "../../../node_modules/swiped-events/src/swiped-events.js [1] searxng#4284 [2] https://www.npmjs.com/package/swiped-events Signed-off-by: Markus Heiser <markus.heiser@darmarit.de> Reported-by: searxng#4198 (comment)
|
Is there a Dockerbuild of this? To test this, I would need an image. |
No, but you could just use searxng:
build: https://github.com/return42/searxng.git#fix-swipwinstead of searxng:
image: ...for testing, see https://docs.docker.com/reference/compose-file/build/#attributes. |
|
my main hosting on purpose has none of these features. So I guess I gonna have to do a local build and push it to my personal registry. would be cool if you guys could add github actions for building images, especially now that dockerhub ratelimits much more. this could also allow for building containers for prs |
|
We had automated, public preview instance builds of PRs once, not sure what happened to them |
|
Okay it's still here, probably GitHub has just frozen the cronjob because the repo has been inactive for a while (ref https://github.com/searxng/preview-environments/blob/main/.github/workflows/look-new-pr-test.yaml). cc @unixfox |
|
lol. I did a manual build an tested it, seems to work fine |
@snoweuph PR is now merged, new docker image should be available in the next ~1h. |
What does this PR do?
[fix] client/simple: add missing "swiped-events" devDependencies (import)
Why is this change important?
In commit 1a3543d in PR-4284 [1] the swiped-events [2] were forgotten to be migrated. In this patch, the event library is added to the
devDependenciesand imported by:How to test this PR locally?
Swipe is discussed in #4198 where this issue is reported [4]
Related issues