-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[mod] isolation of botdetection from SearXNG core #2981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fa61dab to
2310b50
Compare
c73e779 to
866eee8
Compare
da5b486 to
213cc81
Compare
213cc81 to
a29b963
Compare
In PR-2894[1] we isolated botdetection from the limiter, this PR isolates the botdetection from the SearXNG core code. This PR also fixes the issue [2] that the ``server.public_instance`` option needs to activate the limiter. - [1] searxng#2894 - [2] searxng#2975 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
a29b963 to
a2ee107
Compare
|
Not sure if something is going to change about the filenames but if so then we will need to synchronize them with the one located in searxng-docker: https://github.com/searxng/searxng-docker/blob/master/searxng/limiter.toml |
| DEFAULT_CFG = Path(__file__).parent / "limiter.toml" | ||
| """Base configuration (schema) of the botdetection.""" | ||
|
|
||
| LIMITER_CFG = Path('/etc/searxng/limiter.toml') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if something is going to change about the filenames but if so then we will need to synchronize them with the one located in searxng-docker: https://github.com/searxng/searxng-docker/blob/master/searxng/limiter.toml
The LIMITER_CFG kept unchanged.
|
I've started a version with a Flask middleware (prototype not even run, just a bunch of code to explain how the botdetection and searxng can be decoupled): [EDIT] the code and the example work now, however the documentation and comments are not updated. |
|
New update:
|
In PR-2894[1] we isolated botdetection from the limiter, this PR isolates the botdetection from the SearXNG core code.
This PR also fixes the issue [2] that the
server.public_instanceoption needs to activate the limiter.server.public_instancewithoutserver.limiterdoes not sendlink_tokenpings #2975Resources of
botdetectionPackage
botdetectionat PyPi:Repository of
botdetectionat SearXNG org: