[fix] limiter / botdetection: remove http_connection method #2893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: - searxng#2892 (comment) Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Contributor
|
While this may fix some issues with uwsgi, removing this rule reduce the effectiveness of the bot protection. I have seen many many bots sending the connection close header on my server. And this rule have blocked a lot of bots. |
return42
commented
Oct 3, 2023
Comment on lines
51
to
56
| http_accept, | ||
| http_accept_encoding, | ||
| http_accept_language, | ||
| http_connection, | ||
| http_user_agent, | ||
| ip_limit, | ||
| ip_lists, |
Member
Author
There was a problem hiding this comment.
I have seen many many bots sending the connection close header on my server. And this rule have blocked a lot of bots.
After #2894 has been reviewed & merged we can consider to make this rules configurable in the limiter.toml.
Contributor
|
Forgot to say that I'm using NGINX for this rule not the official bot limiter in searxng. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: