[fix] update user agent #2826
Merged
[fix] update user agent #2826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Idea: raise an exception at the version 120, to manually check the effective user agent. --> #2822 (comment) |
378cee7 to
d346563
Compare
Contributor
Author
|
Yeah I agree, I added an exception at 120 |
d346563 to
8bcca0e
Compare
Contributor
Author
|
@return42 I'm not sure how I managed to close this haha, and github isn't showing the changes, but feel free to reopen. My changes are on the branch. |
Member
|
@jazzzooo You're certainly the most overqualified "GitHub staff" I've ever seen 😂 |
Contributor
Author
|
@Bnyro thank you, maybe I'm more of an intern 😆 |
dalf
approved these changes
Sep 25, 2023
Contributor
|
Thank you |
return42
reviewed
Sep 25, 2023
This was referenced Sep 26, 2023
Closed
return42
added a commit
to return42/searxng
that referenced
this pull request
Dec 4, 2023
This reverts commit 3c6549a. Related: - searxng#2826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the User-Agent to be a valid one. Currently the geckoversion rv value is frozen as 109.
Why is this change important?
As dalf found, firefox froze their rv value at 109. This made our User-Agent invalid and led to us being detected as a bot by Bing. This could also have negative effects for other engines.
How to test this PR locally?
Try some searches, make sure no engine is broken by this. Shouldn't be the case tho.