[fix] brave.news #2784
Merged
[fix] brave.news #2784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
oh I noticed the same fix applies to brave.videos, added that too :) |
return42
approved these changes
Sep 15, 2023
Member
return42
left a comment
There was a problem hiding this comment.
Hi @jazzzooo, thanks a lot for your spontaneous analysis 🚀
Anyways, the
js_variable_to_pythondiscussion is off-topic so I will post about it in Discussions.
Sadly I haven't had the time for a deep comparison of chompjs vs js_variable_to_python .. I would be very happy if you start a discussion about this, so that we have an eye on the subject. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the brave news engine by fixing an edge-case of
js_variable_to_python.Why is this change important?
This was not a hard fix, but I have some concerns about the recently added
js_variable_to_pythonthat replaces chompjs. I'm worried about performance, and that it's likely it will break again. In this case it broke because in js you can write the float0.314as.314, saving some bytes. Anyways, thejs_variable_to_pythondiscussion is off-topic so I will post about it in Discussions.How to test this PR locally?
!brnews testRelated issues
Closes #2782