[mod] bing: resolve redirect without additional requests #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
700e6bb to
ce5bdac
Compare
return42
reviewed
Aug 28, 2023
Remove the usage of searx.network.multi_requests The results from Bing contains the target URL encoded in base64 See the u parameter, remove the first two character "a1", and done. Also add a comment the check of the result_len / pageno ( from searx/searx#1387 )
return42
approved these changes
Aug 29, 2023
Member
return42
left a comment
There was a problem hiding this comment.
resolve redirect without additional requests
Seems to work / thanks a lot 👍 (it was long time on my hidden ToDo list)
In my tests I realized, that bing engine needs some more review (not related to this PR):
- time range option
- safe search option
- page no
.. do no longer work / I suppose bing has changed its API in a line with which they promote this AI thing :o
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the usage of searx.network.multi_requests
The results from Bing contains the target URL encoded in base64 See the u parameter, remove the first two character "a1", and done.
Also,
previously, if the number_of_results was lower than the actual result, all the results were ignored. This commit ignore number_of_results but still provides the results.[EDIT] related to searx/searx#1387 (on searx) --> I've added a comment about that
Why is this change important?
Remove the usage of
searx.network.multi_requests. Bing is the only working engine to use this function.From that, we might switch to sync code in
searx.network.Also, this PR make bing a little bit faster ; anyway, bing is already on of the fastest engine.
How to test this PR locally?
make requests on the bing engine.
Author's checklist
It seems https://bing.com does not work at all without javascript (?) : If I type a query in the front page, then press enter, nothing happen.
Related issues