[mod] plugins: minor change #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required attributes: display a different message when the attribute has the wrong type
return42
approved these changes
Aug 16, 2021
Comment on lines
+74
to
+75
| 'attribute "{0}" is of type {2}, must be of type {3}, cannot load plugin: {1}' | ||
| .format(plugin_attr, plugin, type_attr, plugin_attr_type) |
Member
There was a problem hiding this comment.
Nit: I think string replacement by log-function arguments *args consumes less resources when logging is disabled (since the formatted string it is late evaluated), while the format operation of the string is always executed, even if logging is disabled.
Contributor
Author
There was a problem hiding this comment.
Yes, clearly.
sys.exit() just after "hides / solves" the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
required attributes: display a different message when the attribute has the wrong type
Why is this change important?
Tiny change, make #256 minor simple.
How to test this PR locally?
Author's checklist
Related issues
Related #256