这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@liimee
Copy link
Contributor

@liimee liimee commented Aug 6, 2022

What does this PR do?

Adds the wttr.in engine

Why is this change important?

We have no weather engines yet on searxng, so I think this would be cool

How to test this PR locally?

search !wttr San Francisco

Author's checklist

This engine has some hardcoded English text, and I'm not sure how to make it translatable, sorry. We may be able to use their one-line output or image/plain text/html output I'll try to use gettext

Related issues

#1206 may be related

Thanks :)

@liimee liimee force-pushed the eng-wttr branch 2 times, most recently from 7b0d8b4 to 23da894 Compare August 6, 2022 13:27
@return42 return42 self-requested a review August 6, 2022 19:16
@return42
Copy link
Member

return42 commented Aug 7, 2022

Hi @liimee its a pleasure to see PR's from you :)

I recognize continues pushes from you .. if you think PR is ready to review, sent me a note / thanks.

@liimee
Copy link
Contributor Author

liimee commented Aug 8, 2022

@return42 hi, sorry about that — it is now ready for review

@julianfairfax
Copy link

#1206 is indeed related. This would be nice to see!

@liimee
Copy link
Contributor Author

liimee commented Aug 11, 2022

@return42 hello, just reminding you to review this PR if you are not busy, thanks

@return42
Copy link
Member

Hi @liimee sorry for the delay .. its on my ToDo list .. I would prefer it if we can merge #1412 first.

My plan is to ..

for this we need to:

first. If this is done I can add the long needed list-type and a table-type (needed in this PR) to the infobox.

About PR-1412 @dalf says After a long thinking, I'm "meh" about this PR, then we implemented two alternatives to PR-1412 but both did failed ..

If we don't make progress with the PR-1412 for longer, then I can bring this PR forward ... but that would just mean more work for me .. thats why I still wait with this PR .. I hope that is also okay for you.

@dalf dalf self-requested a review September 23, 2022 16:13
@dalf dalf merged commit d3fec13 into searxng:master Sep 23, 2022
@dalf dalf mentioned this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants