-
Notifications
You must be signed in to change notification settings - Fork 2.3k
mudularize & document searx.results and fix #1348 #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI: rebased PR's branch (82 commits) Can we please force merge (review) of this PR? .. beside the bugfix in the second commit, the modularization and documentation from the first commit is a prerequisite for further development of the response types / thanks! |
|
After a long thinking, I'm "meh" about this PR:
|
This is often what I hear .. but it fails in two ways ..
We have a templates .. these templates are undocumented, split up in files and macros .. and we have multiple result types .. how should a newbie understand all this? .. I toked me a week ore more to find all the relations and to write it down .. IMO the lack of so many needed documentation is the reason why this project is so hard to get into .. to be honest, several of your implementations I don't understand because there is no documentation .. that is why I ask dump questions like the one today #1559 .. just one small hint in a docstring of the method of the abstract class about what the meaning is of returning
IDK a better way to document, the doc-strings are in the source code, a few lines above the code that implements what the doc-string described .. compile the docs |
Based on searxng#1412
Based on searxng#1412
Based on searxng#1412
Based on searxng#1412
The intention of this patch is to improve modularization & documentation of the implementations about the *result* items. This patch does not contain any functional change! Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Closes: searxng#1348 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Based on searxng#1412
Based on searxng#1412
Based on searxng#1412
Based on searxng#1412
What does this PR do?
Fix issues with hostname_replace where URLs in answers and infobox not handled.
In preparation for the bugfix, the first commit mudularize & document searx.results.
Why is this change important?
Modularize code, add documentation and fix an issue.
How to test this PR locally?
First check the documentation
make docs.clean docs.liveand visit pages:Second test hostname_replace plugin by redirecting youtube and twitter:
make a search, in the infobox the links should be redirected.
Related issues
Closes: #1348
Supersede: #1356