[feat] engines: add devicons engine #5436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return42
reviewed
Nov 12, 2025
searx/engines/devicons.py
Outdated
Comment on lines
50
to
51
| res.append( | ||
| res.types.LegacyResult( |
Member
There was a problem hiding this comment.
EngineResults is a inheritance of list and has therefore a append method, but we should use the dedicated method res.add ..
searxng/searx/result_types/__init__.py
Lines 65 to 67 in 7a1b959
Member
Author
There was a problem hiding this comment.
Ah, I see. Wouldn't it make sense to add some deprecation warning to EngineResults.append then? I.e.
def add(self, result: Result | LegacyResult):
"""Add a :py:`Result` item to the result list."""
super().append(result)
def append(self, value: Any):
logger.debug("DeprecationWarning: Calling EngineResults.append directly is deprecated, please use EngineResults.add")
self.add(result)- official website: https://devicon.dev/ - the engine contains a lot of icons of popular software frameworks (e.g. pytest), so they could for example be useful for visualizing a diagram of the tech stack used in an app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so they could for example be useful for visualizing a diagram of the tech stack used in an app