-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[mod] typification of SearXNG: add new result type Paper #5208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2882637 to
d18e631
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces typification for paper results in SearXNG by adding a new Paper result type and migrating all paper-based engines from legacy dictionaries to strongly typed result classes.
Key changes:
- Introduces a new
Paperresult class with proper field typing and validation - Refactors the entire search processor architecture with improved type safety
- Updates 11 engines (ADS, Springer Nature, Semantic Scholar, PubMed, etc.) to use the new result types
Reviewed Changes
Copilot reviewed 60 out of 62 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| searx/result_types/paper.py | New Paper result type class with comprehensive field definitions |
| searx/search/processors/*.py | Complete refactor of processor architecture with improved typing |
| searx/engines/*.py | Migration of 11 engines from dict-based to typed Paper results |
| searx/templates/simple/result_templates/paper.html | Updated template with improved layout and new date formatting |
| client/simple/src/less/result_types/paper.less | New dedicated CSS styling for paper results |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d18e631 to
cc9e0b2
Compare
cc9e0b2 to
be213c7
Compare
This patch adds a new result type: Paper - Python class: searx/result_types/paper.py - Jinja template: searx/templates/simple/result_templates/paper.html - CSS (less) client/simple/src/less/result_types/paper.less Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the engine / use of the result type Paper as well as other typifications. The engine has been placed on inactive because no service is currently available, or at least not known in the SearXNG community [1] [1] searxng#3610 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Revision of the Astrophysics Data System (ADS) engine / use of the result type Paper as well as other typifications. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
be213c7 to
db19782
Compare
/// Note: This PR is based on PR #5204 .. please review #5204 first.
This PR adds a new result type: Paper
All engines that used the paper.html template so far have been completely revised and tested / a few engines were defective, but most could at least be improved (including the types from #5204).
For more details go through the commit messages.