[mod] addition of various type hints / engine processors #5204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e2ef7a to
4a539df
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR continues the typification work from #5147 by adding type hints and improving engine processors. It introduces structured request parameter types for different engine types, removes obsolete engine properties, and enhances the currency conversion functionality.
Key changes:
- Adds comprehensive type annotations to all engine processors and their parameter types
- Introduces type-safe parameter classes (OnlineParams, OnlineDictParams, OnlineCurrenciesParams) for different engine types
- Replaces the old engine initialization system with a new setup/init pattern allowing asynchronous initialization
- Removes the obsolete
https_supportproperty from engines
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| searx/search/processors/*.py | Complete type annotation overhaul for all processor classes with structured parameter types |
| searx/engines/*.py | Updates to use new parameter types and removal of obsolete properties |
| searx/data/currencies.py | Enhanced with type annotations and improved currency validation methods |
| searx/search/models.py | Type refinements for SearchQuery class with literal types for enums |
| tests/unit/*.py | Updated to match new processor initialization patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Continuation of searxng#5147 .. typification of the engine processors. BTW: - removed obsolete engine property https_support - fixed & improved currency_convert - engine instances can now implement a engine.setup method [searxng#5147] searxng#5147 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
4a539df to
a0d1c87
Compare
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
a0d1c87 to
6433c4f
Compare
inetol
approved these changes
Sep 18, 2025
return42
pushed a commit
to tiekoetter/searxng
that referenced
this pull request
Sep 20, 2025
Commit 8f8343d [1] introduced a bug in the network logic of SearXNG where stream requests (such as the one from the image proxy) would fail because a wrapper was returned instead of a response object with the correct attribute. This is just a quick in place fix I implemented to get it working again. It would be better to implement corresponding logic to give stream requests the correct object. [1] searxng#5204
return42
pushed a commit
that referenced
this pull request
Sep 20, 2025
Commit 8f8343d [1] introduced a bug in the network logic of SearXNG where stream requests (such as the one from the image proxy) would fail because a wrapper was returned instead of a response object with the correct attribute. This is just a quick in place fix I implemented to get it working again. It would be better to implement corresponding logic to give stream requests the correct object. [1] #5204
return42
added a commit
to return42/searxng
that referenced
this pull request
Sep 24, 2025
This patch is a leftover from PR-5204 [1]. [1] searxng#5204 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Sep 24, 2025
This patch is a leftover from PR-5204 [1]. [1] searxng#5204 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Sep 24, 2025
This patch is a leftover from PR-5204 [1]. [1] searxng#5204 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Sep 24, 2025
This patch is a leftover from PR-5204 [1]. [1] searxng#5204 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Sep 25, 2025
…ring
Issue was introduced by PR-5204 [1]
reported issue::
logger.error("init method of engine %s failed (%s).", eng_proc.engine.name)
TypeError: not enough arguments for format string
[1] searxng#5204
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Sep 25, 2025
This patch is a leftover from PR-5204 [1]. [1] searxng#5204 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
to return42/searxng
that referenced
this pull request
Sep 28, 2025
This patch is a leftover from PR-5204 [1]. [1] searxng#5204 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42
added a commit
that referenced
this pull request
Sep 28, 2025
This patch is a leftover from PR-5204 [1]. [1] #5204 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5147 .. typification of the engine processors.
BTW:
engine.setup()method