[feat] engines: add Marginalia #5087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We should re-add Marginalia because recently, the site owner @vlofgren said that he is okay with it in #3034 It's commented-out in the code, that means only a small number of people will about know about it. Additionaly this sends a User-Agent header to identify searxng traffic. But maybe the python module should include code that prevents the public API key from being used at all? Bassicly give an error instead of allowing it to be used? |
Bnyro
reviewed
Aug 7, 2025
Bnyro
approved these changes
Aug 7, 2025
To get an API key follow instructions at [1]. [1] https://about.marginalia-search.com/article/api/ Related (historical ordered): - searxng#1620 - searxng#1673 - searxng#1627 - searxng#2489 Closes: - searxng#3034
return42
approved these changes
Aug 8, 2025
Member
return42
left a comment
There was a problem hiding this comment.
I pushed a WIP commit on top in which I
- fixed some minor issue (see comments below),
- added online doc for the engine,
- added a
init()routine - and I added some typing stuff.
@Austin-Olacsi can you please check everything works as expected after my modifications / thanks a lot 👍
Bnyro
approved these changes
Aug 8, 2025
Contributor
Author
|
ok we forgot to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds Marginalia
Why is this change important?
Interesting search results.
How to test this PR locally?
uncomment the engine in settings.yml
add your API key, and then use make run
Author's checklist
Related issues
closes #3034