Rework of the developer environment #5018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inetol
reviewed
Jul 17, 2025
Member
inetol
left a comment
There was a problem hiding this comment.
Just a small detail, other than that the changes look good.
inetol
reviewed
Jul 17, 2025
inetol
reviewed
Jul 19, 2025
cbaef5a to
b26c7d9
Compare
Bnyro
reviewed
Jul 25, 2025
Bnyro
reviewed
Jul 25, 2025
Bnyro
reviewed
Jul 25, 2025
Bnyro
approved these changes
Jul 28, 2025
Removes obsolete scripts and fix various leftovers. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
The `go.mod` was created by:: $ ./manage dev.env (dev.env)$ go mod init searxng.org/devtools (dev.env)$ go get -tool mvdan.cc/sh/v3/cmd/shfmt@v3.12.0 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Implement rules and functions to format shell scripts:
$ make format.shell
or alternatively to format all source code:
$ make format
The formatter `shfmt` reads the rules from the editorconfig[1]
If any EditorConfig files are found, they will be used to apply formatting
options. If any parser or printer flags are given to the tool, no
EditorConfig files will be used.
[1] https://github.com/patrickvane/shfmt?tab=readme-ov-file#description
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Pyright has been installed twice so far, once via `package.json` and once in the test script via `npx --no-install`. Separating the type checks in the CI and on the developer desktop is also not necessary. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Member
Author
|
FYI last force push was just to solve a conflict with master branch / I'm going to merge this PR now .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR cleans up the developer environment and enables the use of tools from the Go ecosystem.
The versions of the Node.js and Go tools are pinned and updated by the Dependantbot.
The old LXC scripts have been removed (they have been unusable for some time).
The shell scripts are formatted with
shfmt.... for further details, please read the commit messages.
Related issues