[fix] container: remove static path mount #5006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen that by default Granian sets a `Cache-Control` header for 1 day IF `GRANIAN_STATIC_PATH_MOUNT` is set. This option is not a hard requirement, but it's set because I found to be faster when serving the static files. Another thing is that by removing `GRANIAN_STATIC_PATH_MOUNT`, the headers set by the application are present again in the static files, which was not the case before. Related searxng#5004
Member
Author
|
If there are no objections I will merge this PR in a few hours |
return42
approved these changes
Jul 19, 2025
Member
return42
left a comment
There was a problem hiding this comment.
If there are no objections I will merge this PR in a few hours
Sorry for being such unresponsive .. LGTM, thanks for your deep analyses 👍
inetol
added a commit
to searxng/searxng-docker
that referenced
this pull request
Jul 19, 2025
* [fix] container: remove static hashing Allows browser cache heuristics to properly work. Related searxng/searxng#5006 Closes #409 * [fix] container: don't revalidate at every request As Granian no longer handles static files directly, the whole process goes through Flask, which apart from being slow, is resource intensive, even to serve HTTP 304 responses.
|
@inetol fyi, Granian 2.5.x allows to disable cache headers on static files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen that by default Granian sets a
Cache-Controlheader for 86400 seconds IFGRANIAN_STATIC_PATH_MOUNTis set. This option is not a hard requirement, but it's set because I found to be faster when serving the static files.Another thing is that by removing
GRANIAN_STATIC_PATH_MOUNT, the headers set by the application are present again in the static files, which was not the case before 🤦Having the
GRANIAN_STATIC_PATH_MOUNTset:Without
GRANIAN_STATIC_PATH_MOUNT:Related #5004
Related with issue in searxng/searxng-docker#410 (comment)