Use correct config file on ubuntu 16.04. #30
Conversation
From ubuntu 15.10 to ubuntu 16.04, the locale config file location changed. It used to live at /var/lib/locales/supported.d/local but moved to /etc/locale.gen . This code should manifestly be modified (soon) to understand that we really want "version 16.04 or later". That, oddly, exceeds my puppet-fu. Suggestions most welcome.
|
👍 |
manifests/params.pp
Outdated
| $update_locale_pkg = 'libc-bin' | ||
| } | ||
| } | ||
| case $::operatingsystemrelease { |
There was a problem hiding this comment.
You can use versioncmp to check for the OS version. Versioncmp() outputs 0 if the version is equal and 1 for newer, so versioncmp($::operatingsystemrelease, '16.04') >= 0 should give you Ubuntu Xenial and newer and futureproof this.
A usage example: https://github.com/puppetlabs/puppetlabs-apache/blob/master/manifests/version.pp#L24
|
@JeffAbrahamson Good work. Definitely has my vote, but I've added a suggestion to the PR to make this PR work for 16.10 and future versions too by using versioncmp(). Perhaps you could add this, please? |
|
Thanks for the suggestion (and improvement to my puppet skills). Done and pushed. I think I should really squash those two commits together, but I'm not sure which trumps: that this is my branch on my fork of the repo or that it's now a PR that many can see. So I've simply pushed a squashed branch as well: ubuntu-16.04-squashed to cover my bases. (I'm happy to squash this one as well if that's preferable.) |
From ubuntu 15.10 to ubuntu 16.04, the locale config file location
changed. It used to live at /var/lib/locales/supported.d/local but
moved to /etc/locale.gen .
This code should manifestly be modified (soon) to understand that we
really want "version 16.04 or later". That, oddly, exceeds my
puppet-fu. Suggestions most welcome.