This repository was archived by the owner on Jul 21, 2021. It is now read-only.
Invalidate watchers when error in loop() #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2015 22:49
In loop() function, when network error happens, sendLoop() and recvLoop() returns for reconnection. loop() also flushes existing requests before reconnecting. Yet watchers should be also notified.
Author
|
Looks like some behaviors of error handling are changed because of my patch. I've updated unit test to reflect the patch. Please let me know if the patch looks good. Another solution would be set a maximum retry in connect() function and error if can't reach clusters. |
|
+100 |
jiangjin
added a commit
to datajet-io/kazoo-go
that referenced
this pull request
Aug 11, 2015
|
Looks like there's a merge conflict here. |
e51ba65 to
471cd4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In loop() function, when network error happens, sendLoop() and recvLoop() return for the next connection. loop() also flushes existing requests before reconnecting. Yet watchers should be also notified.
Without the patch watchers won't receive event. And if network error persists, the next connect() would never succeed and watchers will be waiting forever.