这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on Jul 21, 2021. It is now read-only.

Add watcher type and the ability to remove watcher #110

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add watcher type and the ability to remove watcher #110

wants to merge 4 commits into from

Conversation

@tevino
Copy link

@tevino tevino commented Apr 11, 2016

camlistore.org/pkg/throttle is broken, switched to go4.org/net/throttle

  1. GetW ExistsW and ChildrenW return a *Watcher at the position of <-chan Event
  2. The watcher could be removed(thus stopped) by Conn.RemoveWatcher(watcher)
  3. The chan within a manually removed watcher will receive a special
    Event with ErrWatcherRemoved
  4. WatchType and WatchPathType are exported

@tevino tevino force-pushed the watcher branch 9 times, most recently from 1c5ed88 to 8d659ee Compare April 11, 2016 09:51
tevino added 4 commits April 11, 2016 17:57
@tevino
Add watcher type and the ability to remove watcher
81d2ec3 
1. GetW ExistsW and ChildrenW return a *Watcher at the position of <-chan Event
2. The watcher could be removed(thus stopped) by Conn.RemoveWatcher(watcher)
3. The chan within a manually removed watcher will receive a special
   Event with ErrWatcherRemoved
4. WatchType and WatchPathType are exported
@tevino
Fix example code
87e970b
@tevino
Fix tests
1ef0ac1 
camlistore.org/pkg/throttle is broken, switched to go4.org/net/throttle
@tevino
Fix travis
441b9d8
This was referenced Apr 11, 2016
Open
Closed
@cerisier
Copy link

cerisier commented May 5, 2016

Does this have any chance to be merged ? Is there something we can do to help get it merged ?

@tevino
Copy link
Author

tevino commented May 6, 2016

I'm not sure if @samuel is still maintaining this repo.
You can just use the fork (as I did) for now. @cerisier

@samuel samuel force-pushed the master branch 2 times, most recently from e51ba65 to 471cd4e Compare November 17, 2017 19:04
@pantianying pantianying mentioned this pull request Jan 21, 2020
Closed
@pantianying
Copy link

pantianying commented Jan 31, 2020

Does this have any chance to be merged ? Is there something we can do to help get it merged ?

I used this library in my project, which caused a memory leak. The pprof file shows that addwatcher () takes up too much memory, so I want to use removeaddwatcher (). Have you actually used the PR code? My project is https://github.com/apache/dubbo-go，Looking forward to communicating with you

@wanyvic
Copy link

wanyvic commented Mar 4, 2020 •
edited
Loading

I found the same problem from my source code

//conn.go line 950
c.watchersLock.Lock() 
defer c.watchersLock.Unlock() 
ch := make(chan Event, 1)    //canot remove. caused memory leak
wpt := watchPathType{path, watchType} 
c.watchers[wpt] = append(c.watchers[wpt], ch)

@samuel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tevino @cerisier @pantianying @wanyvic