This repository was archived by the owner on Jul 21, 2021. It is now read-only.
Add RemoveWatcher() API #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffe235a to
cb13455
Compare
Author
|
@samuel Any chance for you to help review this PR ? This change should be 100% backward compatible and should not break any existing applications. For those applications that creates large number of watches, this plugs a hole where these watchers are no longer of interests and since these watches may never be triggered, these resources are never released. |
Disable adminserver
e51ba65 to
471cd4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is backward compatible with ZooKeeper 3.4.x, but in order to use the
RemoveWatcherAPI, ZooKeeper 3.5.x or later is required.NOTE:
Connstruct:RemoveWatcher. Existing client code do not have to change since the other API contract is unchanged. But client application can use the new API as needed.ErrUnimplementederror will be returned.Why is this needed ?