-
Notifications
You must be signed in to change notification settings - Fork 0
Adding documentation for FM and COOP/COEP #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Fetch Metadata docs * Added explanations of FM and COOP/COEP * Add docs for COOP and COEP * Update source/security/index.md Co-authored-by: Sal <salchoman@gmail.com> * Update source/security/index.md Co-authored-by: Sal <salchoman@gmail.com> * Removed extra white space * Update source/core-developers/fetch-metadata-interceptor.md Co-authored-by: Sal <salchoman@gmail.com> * Update source/core-developers/fetch-metadata-interceptor.md Co-authored-by: Sal <salchoman@gmail.com> * Update source/core-developers/fetch-metadata-interceptor.md Co-authored-by: Sal <salchoman@gmail.com> * Update source/core-developers/fetch-metadata-interceptor.md Co-authored-by: Sal <salchoman@gmail.com> * Fixes based on PR comments Co-authored-by: Giannis Chatziveroglou <gchatz@mit.edu> Co-authored-by: Sal <salchoman@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general: exemptedPaths
is a parameter that does exact string matching against the path associated with URL requests. That means that the parameter should only receive relative paths with a trailing slash. All parameters have default values, so instead of saying 'this parameter has no default value' we must say 'the default set of exempted paths is empty'. This applies for all the files in this PR.
Additionally, there seems to be a confusion between Fetch Metadata and Resource Isolation Policies. Fetch Metadata specifies what the Sec-Fetch-* headers are and what they mean. Resource Isolation Policies read those headers and take actions depending on their values. This means we should never say "here's how to implement Fetch Metadata" (because only browsers implement that), instead we should say "here's how you can implement a resource isolation policy based on Fetch Metadata headers".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sal!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amost there!
Co-authored-by: Sal <salchoman@gmail.com>
Co-authored-by: Sal <salchoman@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🥇
Moving our changes to your repo so you can later submit a PR upstream!