test: fix tests failing on windows #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
489fe62 to
aea33b7
Compare
Contributor
Author
|
Ready for review. Only test-wasm-i64.js segfaulting on macos-13 remains (and macos 13 goes EOL in three months so maybe not worth the effort to sink a lot of time in?) |
The tests scan stderr of the child process for a particular string. My hypothesis is that, because they don't wait for the child to terminate, there is a race window where the parent tries to read stderr before the child is completely done writing the error message. This problem doesn't manifest on the other buildbots but maybe the Windows buildbots are a little slower, or maybe line buffering works different there, making the problem more apparent.
52aff8c to
2b0c402
Compare
saghul
approved these changes
Aug 23, 2025
Owner
Yeah. I should also get back into replacing wasm3 (as it's unmaintained) with wavm. Thanks Ben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests scan stderr of the child process for a particular string. My hypothesis is that, because they don't wait for the child to terminate, there is a race window where the parent tries to read stderr before the child is completely done writing the error message.
This problem doesn't manifest on the other buildbots but maybe the Windows buildbots are a little slower, or maybe line buffering works different there, making the problem more apparent.