fix low verion gcc build err #635

ririyeye · 2024-08-06T10:23:13Z

/home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:44:34: error: initializer element is not constant { "tjs:assert", tjs__assert, tjs__assert_size }, ^~~~~~~~~~~~~~~~ /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:44:34: note: (near initialization for ‘builtins[0].data_size’) /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:45:28: error: initializer element is not constant { "tjs:ffi", tjs__ffi, tjs__ffi_size }, ^~~~~~~~~~~~~ /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:45:28: note: (near initialization for ‘builtins[1].data_size’) /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:46:36: error: initializer element is not constant { "tjs:getopts", tjs__getopts, tjs__getopts_size }, ^~~~~~~~~~~~~~~~~ /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:46:36: note: (near initialization for ‘builtins[2].data_size’) /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:47:36: error: initializer element is not constant { "tjs:hashing", tjs__hashing, tjs__hashing_size }, ^~~~~~~~~~~~~~~~~ /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:47:36: note: (near initialization for ‘builtins[3].data_size’) /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:48:34: error: initializer element is not constant { "tjs:ipaddr", tjs__ipaddr, tjs__ipaddr_size }, ^~~~~~~~~~~~~~~~ /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:48:34: note: (near initialization for ‘builtins[4].data_size’) /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:49:30: error: initializer element is not constant { "tjs:path", tjs__path, tjs__path_size }, ^~~~~~~~~~~~~~ /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:49:30: note: (near initialization for ‘builtins[5].data_size’) /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:50:46: error: initializer element is not constant { "tjs:posix-socket", tjs__posix_socket, tjs__posix_socket_size }, ^~~~~~~~~~~~~~~~~~~~~~ /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:50:46: note: (near initialization for ‘builtins[6].data_size’) /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:51:34: error: initializer element is not constant { "tjs:sqlite", tjs__sqlite, tjs__sqlite_size }, ^~~~~~~~~~~~~~~~ /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:51:34: note: (near initialization for ‘builtins[7].data_size’) /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:52:30: error: initializer element is not constant { "tjs:uuid", tjs__uuid, tjs__uuid_size }, ^~~~~~~~~~~~~~ /home/wangyang/cross/.xmake/cache/packages/2408/t/txiki.js/v24.6.0/source/txiki.js/src/builtins.c:52:30: note: (near initialization for ‘builtins[8].data_size’)

low version gcc will trig error like this

saghul · 2024-08-06T10:53:08Z

I hate versions trigger that behavior?!

ririyeye · 2024-08-06T12:56:39Z

i tried gcc 7.5 and 5.4 ,it does not work
but gcc 13 works well

saghul · 2024-08-12T07:58:49Z

You'd need to update the code that genrates those C files, since your changes wwould be overwritten otherwise.

That's here:

txiki.js/src/qjsc.c

Line 205 in 93a4ad8

    
           fprintf(fo, "const uint8_t %s%s[%u] = {\n", prefix, c_name, (unsigned int) out_buf_len);

saghul · 2024-08-12T08:58:02Z

You need to run make js to make sure all the C files are generated after your changes. Then commit the result.

saghul · 2024-08-12T09:30:22Z

Ah, one of my PRs now creates a conflict, oh well. Can you rebase?

saghul · 2024-08-12T10:27:51Z

/usr/local/bin/cmake -E cmake_link_script CMakeFiles/tjs-cli.dir/link.txt --verbose=1
/usr/bin/cc -O3 -DNDEBUG "CMakeFiles/tjs-cli.dir/src/cli.c.o" "CMakeFiles/tjs-cli.dir/src/mod_posix-socket.c.o" -o tjs  libtjs.a ffi_root/usr/local/lib/libffi.a deps/quickjs/libqjs.a deps/libuv/libuv.a -ldl -lrt deps/wasm3/source/libm3.a deps/sqlite3/libsqlite3.a -lm -lpthread /usr/lib/x86_64-linux-gnu/libcurl.so deps/mimalloc/libmimalloc.a /usr/lib/x86_64-linux-gnu/libpthread.a /usr/lib/x86_64-linux-gnu/librt.a
/usr/bin/ld: libtjs.a(mod_sys.c.o): warning: relocation against `tjs__run_repl_size' in read-only section `.text'
/usr/bin/ld: libtjs.a(vm.c.o): in function `TJS_NewRuntimeInternal':
/home/runner/work/txiki.js/txiki.js/src/vm.c:341: undefined reference to `tjs__polyfills_size'
/usr/bin/ld: /home/runner/work/txiki.js/txiki.js/src/vm.c:342: undefined reference to `tjs__core_size'
/usr/bin/ld: libtjs.a(vm.c.o): in function `TJS_Run':
/home/runner/work/txiki.js/txiki.js/src/vm.c:505: undefined reference to `tjs__run_main_size'
/usr/bin/ld: libtjs.a(worker.c.o): in function `worker_entry':
/home/runner/work/txiki.js/txiki.js/src/worker.c:386: undefined reference to `tjs__worker_bootstrap_size'
/usr/bin/ld: libtjs.a(mod_sys.c.o): in function `tjs_runRepl':
/home/runner/work/txiki.js/txiki.js/src/mod_sys.c:61: undefined reference to `tjs__run_repl_size'
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE
collect2: error: ld returned 1 exit status

ririyeye · 2024-08-12T10:53:27Z

/usr/local/bin/cmake -E cmake_link_script CMakeFiles/tjs-cli.dir/link.txt --verbose=1
/usr/bin/cc -O3 -DNDEBUG "CMakeFiles/tjs-cli.dir/src/cli.c.o" "CMakeFiles/tjs-cli.dir/src/mod_posix-socket.c.o" -o tjs  libtjs.a ffi_root/usr/local/lib/libffi.a deps/quickjs/libqjs.a deps/libuv/libuv.a -ldl -lrt deps/wasm3/source/libm3.a deps/sqlite3/libsqlite3.a -lm -lpthread /usr/lib/x86_64-linux-gnu/libcurl.so deps/mimalloc/libmimalloc.a /usr/lib/x86_64-linux-gnu/libpthread.a /usr/lib/x86_64-linux-gnu/librt.a
/usr/bin/ld: libtjs.a(mod_sys.c.o): warning: relocation against `tjs__run_repl_size' in read-only section `.text'
/usr/bin/ld: libtjs.a(vm.c.o): in function `TJS_NewRuntimeInternal':
/home/runner/work/txiki.js/txiki.js/src/vm.c:341: undefined reference to `tjs__polyfills_size'
/usr/bin/ld: /home/runner/work/txiki.js/txiki.js/src/vm.c:342: undefined reference to `tjs__core_size'
/usr/bin/ld: libtjs.a(vm.c.o): in function `TJS_Run':
/home/runner/work/txiki.js/txiki.js/src/vm.c:505: undefined reference to `tjs__run_main_size'
/usr/bin/ld: libtjs.a(worker.c.o): in function `worker_entry':
/home/runner/work/txiki.js/txiki.js/src/worker.c:386: undefined reference to `tjs__worker_bootstrap_size'
/usr/bin/ld: libtjs.a(mod_sys.c.o): in function `tjs_runRepl':
/home/runner/work/txiki.js/txiki.js/src/mod_sys.c:61: undefined reference to `tjs__run_repl_size'
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE
collect2: error: ld returned 1 exit status

maybe the first patch is best, and is src/builtins.c a codegen C file?

saghul · 2024-08-12T11:02:54Z

Turns out, yeah! Thanks for giving it a try though.

ririyeye force-pushed the master branch from 3b1931f to 3135701 Compare August 12, 2024 09:58

fix low verion gcc build err

af41e31

ririyeye force-pushed the master branch from 3135701 to af41e31 Compare August 12, 2024 10:53

saghul approved these changes Aug 12, 2024

View reviewed changes

saghul merged commit b50f2f1 into saghul:master Aug 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix low verion gcc build err #635

fix low verion gcc build err #635

Uh oh!

ririyeye commented Aug 6, 2024

Uh oh!

saghul commented Aug 6, 2024

Uh oh!

ririyeye commented Aug 6, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

ririyeye commented Aug 12, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix low verion gcc build err #635

fix low verion gcc build err #635

Uh oh!

Conversation

ririyeye commented Aug 6, 2024

Uh oh!

saghul commented Aug 6, 2024

Uh oh!

ririyeye commented Aug 6, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

ririyeye commented Aug 12, 2024

Uh oh!

saghul commented Aug 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants