Allow embedding txiki in other applications #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a867314 to
46793d7
Compare
saghul
requested changes
May 14, 2024
Owner
saghul
left a comment
There was a problem hiding this comment.
Alright, let's do this! Left some comments.
CMakeLists.txt
Outdated
| target_link_libraries(tjs mimalloc-static) | ||
| endif() | ||
|
|
||
| add_executable(tjs-cli EXCLUDE_FROM_ALL |
Owner
There was a problem hiding this comment.
Don't exclude it, it needs to always be built.
Owner
There was a problem hiding this comment.
If you'd like to only build the library, then add some BUILD_ONLY_LIBRARY option please.
Makefile
Outdated
|
|
||
| $(TJS): $(BUILD_DIR) | ||
| cmake --build $(BUILD_DIR) -j $(JOBS) | ||
| cmake --build $(BUILD_DIR) --target tjs-cli -j $(JOBS) |
Owner
There was a problem hiding this comment.
You don't need this if you don't exclude it.
46793d7 to
124130f
Compare
Contributor
Author
Should be fixed now, let me know if there's anything else. |
saghul
approved these changes
May 15, 2024
Owner
|
Changes LGTM! Let's see if the CI is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks for all the work on txiki.
Currently only a command-line interface is available, but I would like to embed this javascript runtime in my own application.
Is this change something that you would be open to?
It requires only a small adaptation of the CMakeLists.txt and Makefile.
Let me know what you think.