Update Hasklig readme #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Well, first I checked the version in the source fonts and found it to be 1.0 :-o And then I looked at the commit you referenced d4d8d9e, and that commit is broken. Although it adds a patched version to the repo, it does NOT update the source font. And the patched fonts are autogenerated for releases, so ... this commit is completely meaningless. Or am I mistaken? Do you use Hasklig Nerd Font? Has it the changes it should have at rev 1.2? |
Collaborator
|
Ah it is e2745c3 |
Collaborator
|
Ok, version information seems to be broken in the release for https://github.com/i-tu/Hasklig/releases And the file sizes are the same as in the release, so probably we have really |
Collaborator
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patched Hasklig font was updated to use Hasklig v1.2 in d4d8d9e, but the readme was not updated. This PR updates the readme with the appropriate information found here.