Bugfix Symbol Only Mono fonts #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Use of abs() looks like we do not know if the descenders are expected to be positive or negative. But it is well defined. Furthermore on abnormal fonts (where the descenders are nonexisting) we can use the wrong value. Well, that is academic I guess. [how] In our own `ymin` value we store a value like os2_descender, which means that it is on the same axis as the ascender (ymax). Typical values where the baseline is on y-coordinate 0 ymax will be positive and ymin (being below the baseline) will be negative. The total height has to be calculated from adding ascender + -descender (when the descenders are lower than the ascenders, which is guaranteed). The older descender values have positive values; are on an opposite y axis... The height with them would be ascender + descender. Well, WE have in the font_dim os2-like values... Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] If we have an empty input font (i.e. for Symbols Only font) and that font has a gap.. That gap will be redistributed to a gapless font where the ascenders and descenders are expanded to fill/keep the gap. If the font has no height (i.e. == ) and a gap, the height will afterwards be > 0 and the empty font detection breaks. [how] Detect empty fonts before gaps. Fixes: #965 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] We do not want fonts with gap. Gaps are explicitely removed on patching anyhow. Why should the templates have gaps? Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix empty
Symbols Only Nerd Font Monofonts.Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Create a symbols only
Monovariant and look at the glyphs. Are they existing and scaled ok?Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)