font-patcher: Fix checksum algo #961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] For some fonts the calculated checksum(s) was wrong. [how] Misplaced the multiplier ... the LSB shall not be shifted of course, but the current code shifts as last action: Also the LSB is shifted. First shift (old) accumulated content, then add new data. In that way the last added data (LSB) is not shifted. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
For some fonts the calculated checksum(s) was wrong.
[how]
Misplaced the multiplier ... the LSB shall not be shifted of course, but the current code shifts as last action: Also the LSB is shifted.
First shift (old) accumulated content, then add new data. In that way the last added data (LSB) is not shifted.
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
Noticed only after failed runs on
v2.3.0-RCbecause that version number changed the font lengths 👀What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)