Bugfix licenses in archives #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why]
We have 'license' is the archives, but the 'licence' files are missing.
We allow all-caps and all-lowercase, but not camelcase 'License'.
Sometimes we have OFL.txt which is missing.
[how]
Enable both spellings and also camelcase.
Enable OTF text files.
Also fix misunderstanding of regex vs glob ([] vs {}), where the glob
needs a comma and the regex does not.
Add missing LICENSE files for 2 fonts.
Fixes: #979
Reported-by: Jeremy Thorn <moralground>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
In fact these would/will be recreated on a gotta-patch-em-all-font-patcher!.sh run. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Old (renamed) license files are not cleaned up automatically. The new files will be put into the patched-fonts dir, but old ones not removed. [how] With commit afd7ba1 patch-em-all: Purge destination dirs if possible the script purges old font files from the patched-fonts directory to get rid of renamed font files. This has been deliberately limited to ttf and otf files. But as all license files are automatically copied over we can also remove them. This (finally) remove the possibility to manually put any files in those directories. This can be good or bad. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
…chives Bugfix licenses in archives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the release archives (
zipfiles) for some fonts the license file is missing.This fixes this hopefully for the future.
Requirements / Checklist
What does this Pull Request (PR) do?
Autogenerate and keep up to date the license files in
patched-fonts/.Add
OFL.txtto possible (recognized) license files.Add more license file variations to archives.
How should this be manually tested?
Complete CI release run and look into all
zipfiles, for exampleThis lists archive names and license files; there shall be no archive name without a following license file.
Any background context you can provide?
What are the relevant tickets (if any)?
Fixes: #979
Screenshots (if appropriate or helpful)