这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@chapa
Copy link
Contributor

@chapa chapa commented Aug 26, 2022

Description

Adds a link to nerd-fonts-hack AUR package for Nerd Fonts in readme (of all languages).

Requirements / Checklist

How should this be manually tested?

Read and verify each README addition for proper markdown usage.

Any background context you can provide?

I maintain the nerd-fonts-hack AUR package.

@Finii
Copy link
Collaborator

Finii commented Aug 26, 2022

Hmm, seeing all the translations... #887 did not touch translations :-(

In that PR I checked the 'popularity' level or something, that might be meaningless :->

Thanks for the PR!

@chapa
Copy link
Contributor Author

chapa commented Aug 26, 2022

I saw #462 that did so I though they had to be updated too, didn't they ?

I didn't notice this list was meant to be non-exhaustive, feel free to close without merging if the popularity of the package is not high enough (you can see it here)

@Finii
Copy link
Collaborator

Finii commented Aug 26, 2022

The 2.2.0 release aimed mostly to fix bugs in the patcher itself, so the fonts are repatched (with fewer bugs I hope), but that does not mean that the sources have been updated. I do not know how current the Hack source is here.
Updating sources can be the aim of 2.3.0 🤔

The popularity is not so high, but the votes are. Whatever that means.
Will pull it after the release process finished - I fear the release will break if I add more commits while it run. 😬
Patching Noto takes ~5h :-( Just changed the release process to make the release official only after all fonts are ready (at the moment the release is published after the first font is ready 😬

@Finii
Copy link
Collaborator

Finii commented Aug 26, 2022

Merged via a334db4

@Finii Finii closed this Aug 26, 2022
@chapa
Copy link
Contributor Author

chapa commented Aug 27, 2022

Thank you for the explanation, actually even if sources didn't change in 2.2.0 people generally like to have the latest version 😉

FYI popularity is related to votes and time since when the package has been published (votes increases popularity and time decreases it):
image

Thanks for the merge 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants