doc: Correct example patch call through fontforge [skip ci] #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The readme states that one should call `fontforge` with `./fortforge`. That means that no PATH is used, and will usually fail, because the user is in our repo and not in the directory where the fontforge binary resides in. And even if ... then the `font-patcher` script would be somewhere else. That makes no sense. [how] Drop the `./` prefix of the `fontforge` call. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
The readme states that one should call
fontforgewith./fortforge.That means that no PATH is used, and will usually fail, because the user
is in our repo and not in the directory where the fontforge binary
resides in. And even if ... then the
font-patcherscript would besomewhere else. That makes no sense.
[how]
Drop the
./prefix of thefontforgecall.Requirements / Checklist
What does this Pull Request (PR) do?
Fix
readme.mdwith a sanefontforge -script font-patchercall.How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
#268 (comment)
Screenshots (if appropriate or helpful)