Allow running gotta-patch-em-all from any dir #863
Conversation
The script assumes that it's run from inside bin/scripts, by setting source and target directories according to the output of pwd. It doesn't perform any checks whether it's run from the right directory, so it just doesn't find the fonts if the working directory is different. Now it sets the directories relative to the script directory.
|
Dummy comment to invoke bot, according to contributing guidelines. |
Well, it is ... somehow, when you read the comment in the top: # for executing script to rebuild JUST the readmes:
# ./gotta-patch-em-all-font-patcher\!.sh "" infoYou see, it assumes the script to be in the current dir It is there, but not very well documented. Also your change is a good improvement! |
|
It's clear that it's done that way in the README, but not that it has to be done that way. And if I can save writing |
|
Approve ✔️ |
|
Anything still required from my side? Feel free to edit the commit/PR, I'm not passionate about the details. |
Hmm, I was certain that there is a term in the contribution guidelines, that merges / pulls into |
Description
The
gotta-patch-em-all-font-patcher!.shassumes that it's being run from insidebin/scripts, by setting source and target directories according to the output ofpwd.That's not super obvious from the outside. When I tried running it, I didn't know and tried running it from the root dir. That didn't cause an error, but instead the script simply didn't find any fonts.
Now it sets the directories relative to the script directory, which allows running it from anywhere.
What does this Pull Request (PR) do?
Added one line plus comment to the script, to set the script directory (var
sd). Then changed the two instances of${PWD}to instead use${sd}.How should this be manually tested?
Run the script from inside or outside
bin/scripts, see if it works. I'm currently running it from the root dir, and it's working fine so far.