font-patcher: Give meaningful error messages on trivial open fails #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] When the font file is not existing the message we get is either unreadable or missleading (at least for normal users). [how] Explicitely state why we can not open a font file, at least in the cases where we can. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
ryanoasis
approved these changes
Dec 5, 2021
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
…error-msg font-patcher: Give meaningful error messages on trivial open fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[why]
When the font file is not existing the message we get is either
unreadable or misleading (at least for normal users).
[how]
Explicitly state why we can not open a font file, at least in the cases
where we can.
Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons./gotta-patch-em-all-font-patcher\!.sh HermitWhat does this Pull Request (PR) do?
Improve error messages on font open fail.
How should this be manually tested?
Try to patch a non-existing font file. Try to patch a write-only file.
Any background context you can provide?
What are the relevant tickets (if any)?
#512 (comment)
Screenshots (if appropriate or helpful)
With this MR: